Use nested bridging when parse specialization fails.#819
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 7, 2026
Merged
Use nested bridging when parse specialization fails.#819copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_896082192
branch
3 times, most recently
from
8b37625 to
dc95f7c
Compare
Previously, we would always unwrap an error out of `parse_rs_std_template_specialization`. For types like `Option<Proto>` this would lead to failing to format the type because specialization would try to format it in location `Other` when we need to format it as `NestedBridgeable`. We fix this by only unwrapping our error when our location doesn't admit bridging. PiperOrigin-RevId: 896142554
copybara-service
bot
force-pushed
the
test_896082192
branch
from
dc95f7c to
fed62f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use nested bridging when parse specialization fails.
Previously, we would always unwrap an error out of
parse_rs_std_template_specialization. For types likeOption<Proto>this would lead to failing to format the type because specialization
would try to format it in location
Otherwhen we need to format it asNestedBridgeable. We fix this by only unwrapping our error when ourlocation doesn't admit bridging.